Add a virtual ShouldRetry method to the RetryPolicy for customization. #5584

ahsonkhan · 2024-04-29T22:13:16Z

Given this is not meant for end customers to modify, I did not add it to the changelog to avoid highlighting it.

Here is how I would expect the storage use case to be implemented. The StorageRetryPolicy would inherit from RetryPolicy, and override the ShouldRetry method:

  bool ShouldRetry(std::unique_ptr<RawResponse> const& response, RetryOptions const& retryOptions)
      const override
  {
    if (response == nullptr)
    {
      return true;
    }

    if (static_cast<std::underlying_type_t<Azure::Core::Http::HttpStatusCode>>(
            response->GetStatusCode())
        >= 400)
    {
      const auto& headers = response->GetHeaders();
      auto ite = headers.find("x-ms-copy-source-status-code");
      if (ite != headers.end())
      {
        const auto innerStatusCodeInt = std::stoi(ite->second);
        const auto innerStatusCode
            = static_cast<Azure::Core::Http::HttpStatusCode>(innerStatusCodeInt);

        const bool shouldRetry
            = retryOptions.StatusCodes.find(innerStatusCode) != retryOptions.StatusCodes.end();

        if (Azure::Core::Diagnostics::_internal::Log::ShouldWrite(
                Azure::Core::Diagnostics::Logger::Level::Informational))
        {
          Azure::Core::Diagnostics::_internal::Log::Write(
              Azure::Core::Diagnostics::Logger::Level::Informational,
              std::string("x-ms-copy-source-status-code ") + std::to_string(innerStatusCodeInt)
                  + (shouldRetry ? " will be retried" : " won't be retried"));
        }
        if (shouldRetry)
        {
          return true;
        }
      }
    }
    return false;
  }

Follow-up improvement to remove such tight coupling in existing tests: #5585

sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp

Jinming-Hu · 2024-05-06T02:45:06Z

@ahsonkhan can we merge this PR as soon as possible? This is blocking our STG94 work.

RickWinter · 2024-05-06T20:53:34Z

@LarryOsterman can you please review as well.

sdk/core/azure-core/src/http/retry_policy.cpp

ahsonkhan · 2024-05-07T00:59:23Z

can we merge this PR as soon as possible? This is blocking our STG94 work.

@Jinming-Hu We are waiting for this month's release cycle for May before merging this. So, I expect us to get this checked-in by eow. My current thinking is that we beta this as part of Core's release in June and GA it in July to align with when storage needs it.

Jinming-Hu · 2024-05-10T09:34:46Z

@ahsonkhan core release is done. Can we merge this now?

…mization. (Azure#5584)" This reverts commit ab90ef6.

* Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <[email protected]>

* Update vcpkg SHA (#5757) Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8528 (#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8516 (#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8549 (#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Disable codeql as it is causing build issues (#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (#5763) Co-authored-by: Wes Haggard <[email protected]> * Add missing include (#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (#5768) Co-authored-by: James Suplizio <[email protected]> * Provide a walkthrough for how to install the Azure SDK packages in a VS (#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * add the ability to override default succeeded() conditioning by parameter (#5780) Co-authored-by: Scott Beddall <[email protected]> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (#5779) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update vcpkg SHA (#5772) * Show-FailureLogs to include vcpkg build failure logs (#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * Turn federated auth on for Identity tests. (#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (#5792) Co-authored-by: Anton Kolesnyk <[email protected]> * Revert commits related to the new RetryPolicy method (#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8598 (#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Increment package version after release of azure-core (#5794) * Acknowledge community contribution in the changelog (#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Robert Schulze <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: George Arama <[email protected]>

* Update vcpkg SHA (Azure#5757) Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8528 (Azure#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8516 (Azure#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8549 (Azure#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Disable codeql as it is causing build issues (Azure#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (Azure#5763) Co-authored-by: Wes Haggard <[email protected]> * Add missing include (Azure#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (Azure#5768) Co-authored-by: James Suplizio <[email protected]> * Provide a walkthrough for how to install the Azure SDK packages in a VS (Azure#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (Azure#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * add the ability to override default succeeded() conditioning by parameter (Azure#5780) Co-authored-by: Scott Beddall <[email protected]> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (Azure#5779) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update vcpkg SHA (Azure#5772) * Show-FailureLogs to include vcpkg build failure logs (Azure#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * Turn federated auth on for Identity tests. (Azure#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (Azure#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (Azure#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (Azure#5792) Co-authored-by: Anton Kolesnyk <[email protected]> * Revert commits related to the new RetryPolicy method (Azure#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (Azure#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (Azure#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (Azure#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8598 (Azure#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Increment package version after release of azure-core (Azure#5794) * Acknowledge community contribution in the changelog (Azure#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Robert Schulze <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: George Arama <[email protected]>

* Storage/STG95 Files OAuth - full data plane support (#5759) * File OAuth * Remove comment * update test record * [Storage STG95 Branch] Merge Main to fix cmake build error (#5796) * Update vcpkg SHA (#5757) Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8528 (#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8516 (#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8549 (#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Disable codeql as it is causing build issues (#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (#5763) Co-authored-by: Wes Haggard <[email protected]> * Add missing include (#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (#5768) Co-authored-by: James Suplizio <[email protected]> * Provide a walkthrough for how to install the Azure SDK packages in a VS (#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * add the ability to override default succeeded() conditioning by parameter (#5780) Co-authored-by: Scott Beddall <[email protected]> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (#5779) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update vcpkg SHA (#5772) * Show-FailureLogs to include vcpkg build failure logs (#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * Turn federated auth on for Identity tests. (#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (#5792) Co-authored-by: Anton Kolesnyk <[email protected]> * Revert commits related to the new RetryPolicy method (#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 8598 (#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Increment package version after release of azure-core (#5794) * Acknowledge community contribution in the changelog (#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <[email protected]> --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Robert Schulze <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: George Arama <[email protected]> * Storage/STG95 Premium Files Paid Burst (#5795) * paid burst * update record * Storeage/STG95 Files Binary ACE (#5824) * feature code * update test case to playback only * update records * fix cspell * update record * fix cspell * fix cspell * fix comments * Remove copy opreation rest code. * Storage/STG95 Support Sas StringToSign for debugging (#5830) * StringToSign * Update deprecate * Update Func name * ignore deprecated warning * Add missing ignore * fix clang format * Storage/STG95 Resolve Archboard Review Comments (#5856) * fix comments * fix comments * Add Create dir and upload from support (#5866) * merge test recordings * Remove other changes * Remove deprecated (#5873) * Remove others --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Robert Schulze <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: George Arama <[email protected]>

ahsonkhan added 3 commits April 29, 2024 09:33

Add a virtual ShouldTry method to the RetryPolicy for customization.

51f14da

Make test hooks virtual again.

319c503

Add unit test for ShouldRetry.

a0905b5

ahsonkhan added the Azure.Core label Apr 29, 2024

ahsonkhan self-assigned this Apr 29, 2024

ahsonkhan requested review from RickWinter, antkmsft, gearama and LarryOsterman as code owners April 29, 2024 22:13

ahsonkhan changed the title ~~Add a virtual ShouldTry method to the RetryPolicy for customization.~~ Add a virtual ShouldRetry method to the RetryPolicy for customization. Apr 29, 2024

ahsonkhan mentioned this pull request Apr 29, 2024

Remove final keyword for RetryPolicy so that storage SDK can inherit from it #5530

Closed

14 tasks

Fix typo.

bfec526

ahsonkhan mentioned this pull request Apr 29, 2024

Re-write the RetryPolicy unit tests to remove strong coupling with implementation detail which are marked as virtual for mocking #5585

Open

Jinming-Hu approved these changes Apr 30, 2024

View reviewed changes

sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp Outdated Show resolved Hide resolved

LarryOsterman approved these changes May 6, 2024

View reviewed changes

sdk/core/azure-core/src/http/retry_policy.cpp Outdated Show resolved Hide resolved

ahsonkhan added 3 commits May 13, 2024 16:41

Address PR feedback.

1030fbe

Revert making the mock'd functions private for non-test builds.

36ff9da

Add new line.

3294a27

ahsonkhan enabled auto-merge (squash) May 14, 2024 00:28

ahsonkhan merged commit ab90ef6 into Azure:main May 14, 2024
41 checks passed

ahsonkhan deleted the RetryExtension branch May 14, 2024 02:04

ahsonkhan mentioned this pull request May 22, 2024

Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. #5656

Merged

ahsonkhan mentioned this pull request Jul 9, 2024

Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. #5771

Merged

antkmsft added a commit to antkmsft/azure-sdk-for-cpp that referenced this pull request Jul 12, 2024

Revert "Add a virtual ShouldRetry method to the RetryPolicy for custo…

9bc6f8b

…mization. (Azure#5584)" This reverts commit ab90ef6.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a virtual ShouldRetry method to the RetryPolicy for customization. #5584

Add a virtual ShouldRetry method to the RetryPolicy for customization. #5584

ahsonkhan commented Apr 29, 2024 •

edited

Loading

Jinming-Hu commented May 6, 2024

RickWinter commented May 6, 2024

ahsonkhan commented May 7, 2024 •

edited

Loading

Jinming-Hu commented May 10, 2024

Add a virtual ShouldRetry method to the RetryPolicy for customization. #5584

Add a virtual ShouldRetry method to the RetryPolicy for customization. #5584

Conversation

ahsonkhan commented Apr 29, 2024 • edited Loading

Jinming-Hu commented May 6, 2024

RickWinter commented May 6, 2024

ahsonkhan commented May 7, 2024 • edited Loading

Jinming-Hu commented May 10, 2024

ahsonkhan commented Apr 29, 2024 •

edited

Loading

ahsonkhan commented May 7, 2024 •

edited

Loading